Add rdbms matrix for wider compatibility testing#196
Conversation
WyriHaximus
force-pushed
the
0.7.x-add-rdbms-matrix-for-wider-compatibility-testing
branch
5 times, most recently
from
3d2d16b to
b9f6703
Compare
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
Interesting approach, but I'm not sure if we should add this to the same MySQL job here. You suggested to test this with mariadb:10 across all supported PHP versions, but I don't think this is necessary here. Looking further, if we want to support additional databases in different versions, this would result in a huge (and completely confusing) test matrix in GitHub actions.
I think we should test mysql across all supported PHP versions, but for mariadb we could also test against the latest PHP version(s) in a different job to avoid overloading this.
What do you think?
We could introduce MariaDB in a follow up PR.
Givin that MariaDB is a fork by the creator on MySQL, we could flip a could and prefer one of them?
To be brutally honest: Test all permutations; but that is a personal preference that I enforce in my own packages and projects, so I'll make the adjustment for this PR. |
WyriHaximus
force-pushed
the
0.7.x-add-rdbms-matrix-for-wider-compatibility-testing
branch
from
b9f6703 to
249c5fe
Compare
|
@SimonFrings Pushed the changes |
WyriHaximus
force-pushed
the
0.7.x-add-rdbms-matrix-for-wider-compatibility-testing
branch
from
249c5fe to
23da9a7
Compare
This change set introduces a `rdbms` matrix with the purpose of increasing insurance this package works with up to the latest MySQL/MariaDB versions. Note that due to MySQL's versioning there are no `v6` and `v7`. Refs: friends-of-reactphp#194
WyriHaximus
force-pushed
the
0.7.x-add-rdbms-matrix-for-wider-compatibility-testing
branch
from
23da9a7 to
00f1a0c
Compare
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@WyriHaximus Thanks for looking into this, changes LGTM! 
Especially useful once #207 is merged for MySQL 8 and MySQL 9 support! 🎉
WyriHaximus
deleted the
0.7.x-add-rdbms-matrix-for-wider-compatibility-testing
branch
|
@clue Cheers, having a look at 206 and 207 in the next hour 👍 |
3 participants
This change set introduces a
rdbmsmatrix with the purpose of increasing insurance this package works with up to the latest MySQL/MariaDB versions.Note that due to MySQL's versioning there are no
v6andv7.Refs: #194